Bug #63

bug in libdrqueue/communications.c

Added by Redmine Admin over 9 years ago. Updated over 9 years ago.

Status:FixedStart date:
Priority:NormalDue date:
Assignee:Andreas Schröder% Done:

0%

Category:all
Target version:0.64.4

Description

The line 190 of libdrqueue/communications.c, function connect_to_master is like this:
addr.sin_addr = *(struct in_addr *) hostinfo->h_addr;

I have an example execution where hostinfo->h_addr is null, and can't be dereferenced, while hostinfo itself is not null. I suggest changing line 185 to check not only if hostinfo is null but also if hostinfo->h_addr is null.

I reproduced this bug with 0.64.x but the bug is also present in trunk.

History

#1 Updated by Andreas Schröder over 9 years ago

  • Status changed from New to In progress

#2 Updated by Andreas Schröder over 9 years ago

Please have a look on http://drqueue.org/project/changeset/2948 and try it out.

#3 Updated by Redmine Admin over 9 years ago

  • Status changed from In progress to Fixed
  • Resolution set to fixed

I have this change now in production. It is difficult to reproduce the conditions when it crashed. If it fails again I will reopen the ticket, but I don't think so.

Thanks.

Also available in: Atom PDF