Bug #138

Coding standards

Added by Dale B almost 8 years ago. Updated over 7 years ago.

Status:NewStart date:08/24/2010
Priority:HighDue date:
Assignee:-% Done:

0%

Category:all
Target version:0.64.6

Description

Wanting to make a bit of contributions to the code, but I am finding conflicting conventions for doing things in the code. Specifically, the whitespace in most of the drqueue portion seems to be 2 character indentation for each logic loop, but in the DrQueueOnRails portion tabs are being used in some places. Do you have a coding standard document that everyone is following? Something like this, http://www.scribd.com/doc/2889649/Rails-coding-standards-defined or this, http://www.pathf.com/blogs/2008/10/elements-of-ruby-style/ ?

Can we convert the code to a standard? I have a patch for 64.4 job and profiles controllers.

Thanks!

liveoutloud2day

History

#1 Updated by Andreas Schröder almost 8 years ago

Yes, you are right. 2 spaces should be used everywhere in the code.

#2 Updated by Ruben Lopez almost 8 years ago

I suggest using astyle. It is very easy to write a bash script with the right options for astyle so that any contributor can pass this script to modified files before uploading to SCM.

#3 Updated by Andreas Schröder almost 8 years ago

  • Target version set to 0.64.5

#4 Updated by Andreas Schröder over 7 years ago

  • Target version changed from 0.64.5 to 0.64.6

Also available in: Atom PDF